fix(session): use payee as sender in settleOnChain, not fee payer#244
Closed
fix(session): use payee as sender in settleOnChain, not fee payer#244
Conversation
The escrow contract's settle() requires msg.sender == payee. When a feePayer was provided, sendFeePayerTx set the fee payer as both sender and gas sponsor, causing every settlement to revert with NotPayee(). Add an account parameter to settleOnChain and settle() so the payee signs as the tx sender while the fee payer only sponsors gas. Co-Authored-By: grandizzy <38490174+grandizzy@users.noreply.github.com>
Collaborator
|
will carry fwd in #247 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The escrow contract's settle() requires msg.sender == payee. When a feePayer was provided, sendFeePayerTx set the fee payer as both sender and gas sponsor, causing every settlement to revert with NotPayee().
Add an account parameter to settleOnChain and settle() so the payee signs as the tx sender while the fee payer only sponsors gas.